Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1105#discussion_r83445904
  
    --- Diff: proxy/http/HttpConfig.cc ---
    @@ -1224,12 +1224,16 @@ HttpConfig::reconfigure()
     
       params->oride.connect_attempts_max_retries             = 
m_master.oride.connect_attempts_max_retries;
       params->oride.connect_attempts_max_retries_dead_server = 
m_master.oride.connect_attempts_max_retries_dead_server;
    -  params->oride.connect_attempts_rr_retries              = 
m_master.oride.connect_attempts_rr_retries;
    -  params->oride.connect_attempts_timeout                 = 
m_master.oride.connect_attempts_timeout;
    -  params->oride.post_connect_attempts_timeout            = 
m_master.oride.post_connect_attempts_timeout;
    -  params->oride.parent_connect_attempts                  = 
m_master.oride.parent_connect_attempts;
    -  params->per_parent_connect_attempts                    = 
m_master.per_parent_connect_attempts;
    -  params->parent_connect_timeout                         = 
m_master.parent_connect_timeout;
    +  if (m_master.oride.connect_attempts_rr_retries >= 
params->oride.connect_attempts_max_retries) {
    +    Warning("connect_attempts_rr_retries is greater than 
connect_attempts_max_retries, this means requests will never redispatch "
    --- End diff --
    
    Print the actual values here. AFAIK Traffic Server docs don't use the term 
``real``, maybe just say ``will never be retried``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to