Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1108#discussion_r83455610
--- Diff: proxy/InkAPI.cc ---
@@ -1053,15 +1053,14 @@ int
INKVConnInternal::handle_event(int event, void *edata)
{
handle_event_count(event);
- if (m_deleted) {
- if (m_deletable) {
- this->mutex = NULL;
- m_read_vio.set_continuation(NULL);
- m_write_vio.set_continuation(NULL);
- INKVConnAllocator.free(this);
- }
- } else {
+ // If the VConn isn't deleted, call the handler
+ if (!m_deleted) {
return m_event_func((TSCont) this, (TSEvent) event, edata);
+ } else {
--- End diff --
@igalic This handler shouldn't be called after the VConn was destroyed. The
else exists soely to get the assert in there (for debug builds)-- because if we
hit that `else` path there is a bug-- but we don't want ATS to crash on it if
possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
