Github user jpeach commented on the issue:

    https://github.com/apache/trafficserver/pull/1097
  
    No I think it is trivial to remove the global and we should just do it
    
    > On Oct 18, 2016, at 7:29 AM, John J. Rushford <notificati...@github.com> 
wrote:
    > 
    > @jrushford commented on this pull request.
    > 
    > In iocore/eventsystem/I_IOBuffer.h:
    > 
    > > @@ -58,6 +58,7 @@ class VIO;
    >  inkcoreapi extern int64_t max_iobuffer_size;
    >  extern int64_t default_small_iobuffer_size;
    >  extern int64_t default_large_iobuffer_size; // matched to size of OS 
buffers
    > +extern int iobuffer_advice;
    > @jpeach I'd like to land this as is and write a JIRA to come back to the 
global variable once we've had time to evaluate this. Are you okay with this?
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub, or mute the thread.
    > 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to