[ 
https://issues.apache.org/jira/browse/TS-4979?focusedWorklogId=30810&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30810
 ]

ASF GitHub Bot logged work on TS-4979:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Oct/16 16:22
            Start Date: 18/Oct/16 16:22
    Worklog Time Spent: 10m 
      Work Description: Github user zwoop commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/1116#discussion_r83893797
  
    --- Diff: proxy/http/HttpTransact.cc ---
    @@ -1075,6 +1073,8 @@ HttpTransact::ModifyRequest(State *s)
       if (!request.is_target_in_url()) {
         s->hdr_info.client_req_is_server_style = true;
       }
    +  // Make Coverity happy. hostname is non-null iff 
request.is_target_in_url().
    --- End diff --
    
    Since we're bike shedding, this probably should have said "clang-analyzer". 
;-)


Issue Time Tracking
-------------------

    Worklog Id:     (was: 30810)
    Time Spent: 50m  (was: 40m)

> clang-analyzer error in HttpTransact.cc
> ---------------------------------------
>
>                 Key: TS-4979
>                 URL: https://issues.apache.org/jira/browse/TS-4979
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Leif Hedstrom
>            Assignee: Alan M. Carroll
>             Fix For: 7.1.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> {code}
>     if (mimefield_value_equal(host_field, *host_val, host_val_len) == false) {
> 7
> ←
> Passing null pointer value via 2nd parameter 'value'  
> →
> 8
> ←
> Calling 'mimefield_value_equal'       
> →
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to