[ 
https://issues.apache.org/jira/browse/TS-4978?focusedWorklogId=30844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30844
 ]

ASF GitHub Bot logged work on TS-4978:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Oct/16 20:16
            Start Date: 18/Oct/16 20:16
    Worklog Time Spent: 10m 
      Work Description: Github user SolidWallOfCode commented on a diff in the 
pull request:

    https://github.com/apache/trafficserver/pull/1120#discussion_r83940469
  
    --- Diff: iocore/net/SSLConfig.cc ---
    @@ -253,8 +253,8 @@ SSLConfigParams::initialize()
       ats_free(CACertRelativePath);
     
     #if HAVE_OPENSSL_SESSION_TICKETS
    -  REC_ReadConfigStringAlloc(ticket_key_filename, 
"proxy.config.ssl.server.ticket_key.filename");
    --- End diff --
    
    Why not just embed the call in the `if`?
    ```
    if (REC_ERR_OKAY == REC_ReadConfigString(...)) {
    ```


Issue Time Tracking
-------------------

    Worklog Id:     (was: 30844)
    Time Spent: 20m  (was: 10m)

> CID 1364311:  Memory - illegal accesses  (USE_AFTER_FREE) in 
> iocore/net/SSLConfig.cc
> ------------------------------------------------------------------------------------
>
>                 Key: TS-4978
>                 URL: https://issues.apache.org/jira/browse/TS-4978
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TLS
>            Reporter: Leif Hedstrom
>            Assignee: Syeda Persia Aziz
>             Fix For: 7.1.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I think this is perhaps from TS-4858:
> {code}
> *** CID 1364311:  Memory - illegal accesses  (USE_AFTER_FREE)
> /iocore/net/SSLConfig.cc: 258 in SSLConfigParams::initialize()()
> 252       ats_free(ssl_server_ca_cert_filename);
> 253       ats_free(CACertRelativePath);
> 254     
> 255     #if HAVE_OPENSSL_SESSION_TICKETS
> 256       REC_ReadConfigStringAlloc(ticket_key_filename, 
> "proxy.config.ssl.server.ticket_key.filename");
> 257       if (this->ticket_key_filename != NULL) {
>    CID 1364311:  Memory - illegal accesses  (USE_AFTER_FREE)
>    Passing freed pointer "this->ticket_key_filename" as an argument to 
> "relative_to".
> 258         ats_scoped_str 
> ticket_key_path(Layout::relative_to(this->serverCertPathOnly, 
> this->ticket_key_filename));
> 259         default_global_keyblock = 
> ssl_create_ticket_keyblock(ticket_key_path);
> 260       } else {
> 261         default_global_keyblock = ssl_create_ticket_keyblock(NULL);
> 262       }
> 263     #endif
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to