[
https://issues.apache.org/jira/browse/TS-4399?focusedWorklogId=30902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30902
]
ASF GitHub Bot logged work on TS-4399:
--------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/16 03:47
Start Date: 20/Oct/16 03:47
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1073#discussion_r84208323
--- Diff: mgmt/LocalManager.cc ---
@@ -239,8 +239,9 @@ LocalManager::LocalManager(bool proxy_on) :
BaseManager(), run_proxy(proxy_on),
process_server_timeout_msecs =
REC_readInteger("proxy.config.lm.pserver_timeout_msecs", &found);
proxy_name = REC_readString("proxy.config.proxy_name",
&found);
proxy_binary =
REC_readString("proxy.config.proxy_binary", &found);
- proxy_options =
REC_readString("proxy.config.proxy_binary_opts", &found);
env_prep = REC_readString("proxy.config.env_prep",
&found);
+ proxy_options = new char[1];
+ strcpy(proxy_options, ""); // so later we can always `delete
proxy_options` without worrying
--- End diff --
You don't need this. It is safe for ``proxy_options`` to be NULL.
Issue Time Tracking
-------------------
Worklog Id: (was: 30902)
Time Spent: 1h (was: 50m)
> Management API breaks diagnostic log rotation
> ---------------------------------------------
>
> Key: TS-4399
> URL: https://issues.apache.org/jira/browse/TS-4399
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging, Management API
> Reporter: James Peach
> Assignee: Daniel Xu
> Fix For: 7.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Start up Traffic Server:
> {code}
> 0 26950 1 0 10:13AM ?? 0:00.01 /opt/ats/bin/traffic_cop
> -2 26951 26950 0 10:13AM ?? 0:00.02 /opt/ats/bin/traffic_manager
> --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr
> /opt/ats/var/log/trafficserver/traffic.out
> -2 26952 26951 0 10:13AM ?? 0:00.08 /opt/ats/bin/traffic_server
> -M --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr
> /opt/ats/var/log/trafficserver/traffic.out --httpport 8080:fd=12
> {code}
> Now restart it using {{traffic_line -S}} followed by {{traffic_line -U}}:
> {code}
> 0 26950 1 0 10:13AM ?? 0:00.01 /opt/ats/bin/traffic_cop
> -2 26951 26950 0 10:13AM ?? 0:00.05 /opt/ats/bin/traffic_manager
> --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr
> /opt/ats/var/log/trafficserver/traffic.out
> -2 26967 26951 0 10:13AM ?? 0:00.12 /opt/ats/bin/traffic_server
> -M --httpport 8080:fd=20
> {code}
> Note that we lost the {{\--bind_stdout}} and {{\--bind_stderr}} options.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
