Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1133#discussion_r84770706
--- Diff: plugins/header_rewrite/parser.cc ---
@@ -133,14 +152,15 @@ Parser::preprocess(std::vector<std::string> tokens)
std::string s = tokens[0].substr(2, tokens[0].size() - 3);
_op = s;
- if (tokens.size() > 2 && (tokens[1][0] == '=' || tokens[1][0] == '>'
|| tokens[1][0] == '<')) { // cond + (=/</>) + argument
+ if (tokens.size() > 2 && (tokens[1][0] == '=' || tokens[1][0] == '>'
|| tokens[1][0] == '<')) {
+ // cond + [=<>] + argument
_arg = tokens[1] + tokens[2];
} else if (tokens.size() > 1) {
+ // This is for the regular expression, which for some reason has
its own handling?? ToDo: Why ?
--- End diff --
The comment? It's what it says, that case is for the regular expression
case, I kinda wish we had treated / as the other operators (=, < and >), but we
do not. And I don't think this is the time to change that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
