[
https://issues.apache.org/jira/browse/TS-4865?focusedWorklogId=31115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31115
]
ASF GitHub Bot logged work on TS-4865:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/16 19:52
Start Date: 26/Oct/16 19:52
Worklog Time Spent: 10m
Work Description: GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/1144
TS-4865: Fix CID 1362785, CID 1362784
- [TS-4865](https://issues.apache.org/jira/browse/TS-4865)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaori335/trafficserver ts-4865
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1144
----
commit 6fef99ab495ddf68cdb135dece2f9827d11ba72a
Author: Masaori Koshiba <[email protected]>
Date: 2016-10-26T18:59:32Z
TS-4865: Fix CID 1362785, CID 1362784
----
Issue Time Tracking
-------------------
Worklog Id: (was: 31115)
Time Spent: 10m
Remaining Estimate: 0h
> CID 1362785, CID 1362784: Error handling issues (CHECKED_RETURN in server
> push example
> ----------------------------------------------------------------------------------------
>
> Key: TS-4865
> URL: https://issues.apache.org/jira/browse/TS-4865
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: Masaori Koshiba
> Labels: Coverity
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1362785: Error handling issues (CHECKED_RETURN)
> /example/server-push/server-push.c: 50 in should_push()
> 44
> 45 bool
> 46 should_push(TSHttpTxn txnp)
> 47 {
> 48 TSMBuffer mbuf;
> 49 TSMLoc hdr, url;
> CID 1362785: Error handling issues (CHECKED_RETURN)
> Calling "TSHttpTxnClientReqGet" without checking return value (as is done
> elsewhere 45 out of 47 times).
> 50 TSHttpTxnClientReqGet(txnp, &mbuf, &hdr);
> 51 TSHttpHdrUrlGet(mbuf, hdr, &url);
> 52 int len;
> 53 TSUrlHttpQueryGet(mbuf, url, &len);
> 54 TSHandleMLocRelease(mbuf, hdr, url);
> 55 TSHandleMLocRelease(mbuf, TS_NULL_MLOC, hdr);
> ** CID 1362784: Error handling issues (CHECKED_RETURN)
> /example/server-push/server-push.c: 51 in should_push()
> ________________________________________________________________________________________________________
> *** CID 1362784: Error handling issues (CHECKED_RETURN)
> /example/server-push/server-push.c: 51 in should_push()
> 45 bool
> 46 should_push(TSHttpTxn txnp)
> 47 {
> 48 TSMBuffer mbuf;
> 49 TSMLoc hdr, url;
> 50 TSHttpTxnClientReqGet(txnp, &mbuf, &hdr);
> CID 1362784: Error handling issues (CHECKED_RETURN)
> Calling "TSHttpHdrUrlGet" without checking return value (as is done
> elsewhere 32 out of 36 times).
> 51 TSHttpHdrUrlGet(mbuf, hdr, &url);
> 52 int len;
> 53 TSUrlHttpQueryGet(mbuf, url, &len);
> 54 TSHandleMLocRelease(mbuf, hdr, url);
> 55 TSHandleMLocRelease(mbuf, TS_NULL_MLOC, hdr);
> 56 if (len > 0) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
