[
https://issues.apache.org/jira/browse/TS-5005?focusedWorklogId=31128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31128
]
ASF GitHub Bot logged work on TS-5005:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/16 21:40
Start Date: 26/Oct/16 21:40
Worklog Time Spent: 10m
Work Description: GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1146
TS-5005: CID 1364117: Explicit null dereferenced in HttpSM.cc
Probably benign, since the vc shouldn't be NULL, but coverity is ruling
with an iron fist.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-5005
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1146
----
commit b5fe8371a22ab812eecf4366ac451a2563c29ad4
Author: Leif Hedstrom <[email protected]>
Date: 2016-10-26T21:39:16Z
TS-5005: CID 1364117: Explicit null dereferenced in HttpSM.cc
----
Issue Time Tracking
-------------------
Worklog Id: (was: 31128)
Time Spent: 10m
Remaining Estimate: 0h
> CID 1364117: Explicit null dereferenced in HttpSM.cc
> ----------------------------------------------------
>
> Key: TS-5005
> URL: https://issues.apache.org/jira/browse/TS-5005
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, HostDB
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> 7. Condition use_client_addr, taking true branch
>
> CID 1364117 (#2 of 2): Explicit null dereferenced (FORWARD_NULL)
> 8. var_deref_model: Passing null pointer client_addr to find_ip, which
> dereferences it. [show details]
> 2137 if (use_client_addr && rr->find_ip(client_addr) == NULL) {
> 2138 DebugSM("http", "use_client_target_addr == 1. Client specified
> address is not in the pool, not validated.");
> 2139 t_state.dns_info.lookup_validated = false;
> 2140 } else {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
