[
https://issues.apache.org/jira/browse/TS-4855?focusedWorklogId=31129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31129
]
ASF GitHub Bot logged work on TS-4855:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/16 21:45
Start Date: 26/Oct/16 21:45
Worklog Time Spent: 10m
Work Description: GitHub user calavera opened a pull request:
https://github.com/apache/trafficserver/pull/1147
[TS-4855] Make `const char` consistent accross the project.
This change makes `const char` the default format before `char const`.
Searching through the code, it looks like there are more usages of `const
char`, so it looks normal and easier to adopt that terminology:
```
➜ trafficserver git:(fix_const_char_inconsistency) ag 'char const' -o
--nogroup | wc -l
577
➜ trafficserver git:(fix_const_char_inconsistency) ag 'const char' -o
--nogroup | wc -l
6897
➜ trafficserver git:(fix_const_char_inconsistency)
```
Signed-off-by: David Calavera <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/calavera/trafficserver
fix_const_char_inconsistency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1147
----
commit 471d9ec72e2ae5f1994ce3afae58fd2fbe5e16af
Author: David Calavera <[email protected]>
Date: 2016-10-26T21:41:59Z
[TS-4855] Make `const char` consistent accross the project.
Signed-off-by: David Calavera <[email protected]>
----
Issue Time Tracking
-------------------
Worklog Id: (was: 31129)
Time Spent: 10m
Remaining Estimate: 0h
> Make const char vs char const consistent in TS API
> --------------------------------------------------
>
> Key: TS-4855
> URL: https://issues.apache.org/jira/browse/TS-4855
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Susan Hinrichs
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Noted by [[email protected]] while reviewing PR for TS-4703. We use both
> "const char" and "char const" in the TS API prototypes. Should pick one and
> be consistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
