[
https://issues.apache.org/jira/browse/TS-5008?focusedWorklogId=31166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31166
]
ASF GitHub Bot logged work on TS-5008:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/16 22:41
Start Date: 26/Oct/16 22:41
Worklog Time Spent: 10m
Work Description: GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1149
TS-5008 CID 1022007 Logically dead code
The first "if (in_ext_map)" and if (ret) return ret; causes the following
code if (in_ext_map) to never execute. Modified to clean it up.
if (in_ext_map) {
612 ret = true;
613 }
614
615 if (ret) {
616 return ret;
617 }
618
619 if (ink_hash_table_lookup(our_map, virt_ip, &hash_value) != 0) {
const: At condition in_ext_map, the value of in_ext_map must be equal
to 0.
dead_error_condition: The condition in_ext_map cannot be true.
620 if (in_ext_map) {
CID 1022007 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: ret = true;.
621 ret = true;
622 } else {
623 ret = false;
624 }
625 }
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngara/trafficserver TS-5008
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1149
----
commit b28f57089ec63eafa8170b24423538214ec27e67
Author: Nathan Garabedian <[email protected]>
Date: 2016-10-26T22:30:31Z
TS-5008 CID 1022007 Logically dead code
----
Issue Time Tracking
-------------------
Worklog Id: (was: 31166)
Time Spent: 10m
Remaining Estimate: 0h
> CID 1022007 Logically dead code
> -------------------------------
>
> Key: TS-5008
> URL: https://issues.apache.org/jira/browse/TS-5008
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Nathan Garabedian
> Time Spent: 10m
> Remaining Estimate: 0h
>
> if (ink_hash_table_lookup(our_map, virt_ip, &hash_value) != 0) {
> const: At condition in_ext_map, the value of in_ext_map must be equal
> to 0.
> dead_error_condition: The condition in_ext_map cannot be true.
> 620 if (in_ext_map) {
>
> CID 1022007 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: ret = true;.
> 621 ret = true;
> 622 } else {
> 623 ret = false;
> 624 }
> 625 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
