[
https://issues.apache.org/jira/browse/TS-4578?focusedWorklogId=31330&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31330
]
ASF GitHub Bot logged work on TS-4578:
--------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/16 04:50
Start Date: 29/Oct/16 04:50
Worklog Time Spent: 10m
Work Description: Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/1079
If the HttpSM skips hostdb not only does it skip the DNS lookup (which as
@jpeach mentioned is already skipped) this will skip all `last_failure`
detection. So, it seems that the assumption is that if the destination is
localhost its okay to not check -- which IMO is wrong because its just another
endpoint to talk to, so we want to have consistent behavior. IMO we should
remove this special casing for localhost all together.
Issue Time Tracking
-------------------
Worklog Id: (was: 31330)
Time Spent: 20m (was: 10m)
> Skip HostDB lookup for all address literals
> -------------------------------------------
>
> Key: TS-4578
> URL: https://issues.apache.org/jira/browse/TS-4578
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core, DNS
> Reporter: James Peach
> Assignee: David Ben Zakai
> Labels: newbie
> Fix For: sometime
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In {{HttpSM.cc}}:
> {code}
> if ((strncmp(t_state.dns_info.lookup_name, "127.0.0.1", 9) == 0 ||
> strncmp(t_state.dns_info.lookup_name, "::1", 3) == 0) &&
> ats_ip_pton(t_state.dns_info.lookup_name, t_state.host_db_info.ip())
> == 0) {
> // If it's 127.0.0.1 or ::1 don't bother with hostdb
> DebugSM("dns", "[HttpTransact::HandleRequest] Skipping DNS lookup for
> %s because it's loopback",
> t_state.dns_info.lookup_name);
> t_state.dns_info.lookup_success = true;
> call_transact_and_set_next_state(NULL);
> break;
> {code}
> There's no reason to restrict address literals to loopback. It seems like we
> should be able to do this for all address literals.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
