Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1166#discussion_r85968661
  
    --- Diff: plugins/gzip/gzip.cc ---
    @@ -480,8 +480,8 @@ gzip_transformable(TSHttpTxn txnp, bool server, 
HostConfiguration *host_configur
     
       resp_status = TSHttpHdrStatusGet(bufp, hdr_loc);
     
    -  // conservatively pick some statusses to compress
    -  if (!(resp_status == 200 || resp_status == 404 || resp_status == 500)) {
    +  // conservatively pick some statusses to compress. ToDo: Make this 
configurable?
    +  if (resp_status != 200) {
    --- End diff --
    
    @oschaaf  It is *possible*, but unlikely. The immediate issues we're having 
is that gzip works very poorly together with the escalate plugin, but you 
wouldn't escalate on a 200 OK. Long term, @meeramn is going to add a new plugin 
API, that enforces uniqueness on the continuations added to a hook.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to