[ https://issues.apache.org/jira/browse/TS-4732?focusedWorklogId=31410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31410 ]
ASF GitHub Bot logged work on TS-4732: -------------------------------------- Author: ASF GitHub Bot Created on: 01/Nov/16 22:38 Start Date: 01/Nov/16 22:38 Worklog Time Spent: 10m Work Description: GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1169 TS-4732: Changing the do_io_read API so it can be called with NULL and 0 byte values. Allowing do_io_read and do_io_write to not warn on closed connection when we are only trying to disable the reads and writes for it. Removed some macros that were used in a few places (not all the time) and a couple that were not used at all. (cherry picked from commit 1975d679663453348057bb7155bdd3c17ac73880) You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver 6.2.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1169 ---- commit 0b5f8dd430abf196587b7b2c07d58651c36bbfac Author: Bryan Call <bc...@apache.org> Date: 2016-08-12T18:00:11Z TS-4732: Changing the do_io_read API so it can be called with NULL and 0 byte values. Allowing do_io_read and do_io_write to not warn on closed connection when we are only trying to disable the reads and writes for it. Removed some macros that were used in a few places (not all the time) and a couple that were not used at all. (cherry picked from commit 1975d679663453348057bb7155bdd3c17ac73880) ---- Issue Time Tracking ------------------- Worklog Id: (was: 31410) Time Spent: 1h 40m (was: 1.5h) > Still seeing VC errors on master > -------------------------------- > > Key: TS-4732 > URL: https://issues.apache.org/jira/browse/TS-4732 > Project: Traffic Server > Issue Type: Bug > Components: Network > Affects Versions: 6.2.0 > Reporter: Bryan Call > Assignee: Bryan Call > Priority: Blocker > Fix For: 7.0.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Seeing this in the error logs *a lot*: > {code} > [Jun 13 17:14:26.606] Server {0x2b1a9f010700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x634000c186a0, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:26.606] Server {0x2b1a9f010700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x634000c186a0, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:26.631] Server {0x2b1a9e3eb700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x634000c0f220, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:26.631] Server {0x2b1a9e3eb700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x634000c0f220, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:26.727] Server {0x2b1aa0433700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x634000c13240, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:26.727] Server {0x2b1aa0433700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x634000c13240, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:26.765] Server {0x2b1aa083a700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x6340002364e0, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:26.765] Server {0x2b1aa083a700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x6340002364e0, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:26.914] Server {0x2b1a9e7f2700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x63400088c2e0, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:26.914] Server {0x2b1a9e7f2700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x63400088c2e0, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:26.938] Server {0x2b1a9e3eb700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x6340004f7fe0, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:26.938] Server {0x2b1a9e3eb700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x6340004f7fe0, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:27.004] Server {0x2b1aa3487700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x63400025a860, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:27.004] Server {0x2b1aa3487700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x63400025a860, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:27.048] Server {0x2b1aa144f700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x634000ad2820, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:27.048] Server {0x2b1aa144f700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x634000ad2820, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:27.248] Server {0x2b1a9dbdd700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x6340003fa1a0, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:27.248] Server {0x2b1a9dbdd700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x6340003fa1a0, cont (nil), nbytes 0, reader (nil) > [Jun 13 17:14:27.388] Server {0x2b1aa3080700} ERROR: > <UnixNetVConnection.cc:629 (do_io_read)> do_io_read invoked on closed vc > 0x634000807f60, cont (nil), nbytes 0, buf (nil) > [Jun 13 17:14:27.388] Server {0x2b1aa3080700} ERROR: > <UnixNetVConnection.cc:653 (do_io_write)> do_io_write invoked on closed vc > 0x634000807f60, cont (nil), nbytes 0, reader (nil) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)