[
https://issues.apache.org/jira/browse/TS-4391?focusedWorklogId=31485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31485
]
ASF GitHub Bot logged work on TS-4391:
--------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/16 21:00
Start Date: 02/Nov/16 21:00
Worklog Time Spent: 10m
Work Description: GitHub user jrushford opened a pull request:
https://github.com/apache/trafficserver/pull/1177
TS-4391: Duplicated parent origin retry types
(cherry picked from commit 6d4637ce33ab5375cb03c06899f7ab15eb293e7e)
conflicts were properly resolved.
Conflicts:
proxy/http/HttpTransact.cc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jrushford/trafficserver ts-4391
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1177
----
----
Issue Time Tracking
-------------------
Worklog Id: (was: 31485)
Time Spent: 1h (was: 50m)
> Duplicated parent origin retry types
> ------------------------------------
>
> Key: TS-4391
> URL: https://issues.apache.org/jira/browse/TS-4391
> Project: Traffic Server
> Issue Type: Bug
> Components: Parent Proxy
> Reporter: James Peach
> Assignee: John Rushford
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We have:
> {code}
> enum ParentRetry_t {
> PARENT_RETRY_NONE = 0,
> PARENT_RETRY_SIMPLE = 1,
> PARENT_RETRY_UNAVAILABLE_SERVER = 2,
> // both simple and unavailable server retry
> PARENT_RETRY_BOTH = 3
> };
> {code}
> and
> {code}
> enum ParentOriginRetry_t {
> PARENT_ORIGIN_UNDEFINED_RETRY = 0x0,
> PARENT_ORIGIN_SIMPLE_RETRY = 0x1,
> PARENT_ORIGIN_UNAVAILABLE_SERVER_RETRY = 0x2
> };
> {code}
> The parent selection configuration sets values in terms of {{ParentRetry_t}}
> but the transaction state machine checks {{ParentOriginRetry_t}}. We need to
> define these once and use them consistently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)