Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/769#discussion_r83323558
--- Diff: proxy/http/remap/RemapConfig.cc ---
@@ -1153,6 +1169,9 @@ remap_parse_config_bti(const char *path,
BUILD_TABLE_INFO *bti)
goto MAP_ERROR;
}
+ // update sticky flag
+ bti->accept_check_p = bti->accept_check_p &&
(bool)bti->ip_allow_check_enabled_p;
--- End diff --
What about `bti->accept_check_p &&= bit->ip_allow_check_enabled_p;` ? Is
the cast to `bool` required? I would think `ip_allow_check_enabled_p` to be
declared as `bool`. Also, I'm not sure this is the correct place to update the
sticky flag. Activating other filters should have no effect on the sticky flag,
only defining rules. I'l look at at putting it back around line 128, after the
update to the rule flag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
