[
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31795
]
ASF GitHub Bot logged work on TS-1257:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/16 16:12
Start Date: 08/Nov/16 16:12
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1212#discussion_r87022320
--- Diff: iocore/net/SSLUtils.cc ---
@@ -141,8 +142,9 @@ static int ssl_vc_index = -1;
static ink_mutex *mutex_buf = nullptr;
static bool open_ssl_initialized = false;
-RecRawStatBlock *ssl_rsb = nullptr;
-static InkHashTable *ssl_cipher_name_table = nullptr;
+RecRawStatBlock *ssl_rsb = nullptr;
+typedef std::unordered_map<const char *, intptr_t> cipherTable;
--- End diff --
This hashes on the pointer value, not on the string value. I'm not sure
that OpenSSL guarantees to give the same pointer values when you fish them out
of the SSL context.
Issue Time Tracking
-------------------
Worklog Id: (was: 31795)
Time Spent: 50m (was: 40m)
> Replace Tcl_Hash* with lib/ts/Map
> ---------------------------------
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup, Core
> Reporter: Igor Galić
> Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have
> already discussed looking into removing the old Tcl cruft by replacing it
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be
> discussed/decided/evaluated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
