[
https://issues.apache.org/jira/browse/TS-5027?focusedWorklogId=31900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31900
]
ASF GitHub Bot logged work on TS-5027:
--------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/16 01:51
Start Date: 10/Nov/16 01:51
Worklog Time Spent: 10m
Work Description: GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/1215
TS-5027: Replace readdir_r with readdir.
Glibc deprecated readdir_r(3), so replace it with readdir(3). We
were already using readdir(3) in many places so this is just accepting
the inevitable.
(cherry picked from commit 25b16f763267546c0585fb15f43da4a7803ac984)
Conflicts:
mgmt/FileManager.cc
mgmt/MultiFile.cc
mgmt/Rollback.cc
mgmt/WebMgmtUtils.cc
proxy/http/HttpBodyFactory.cc
proxy/logging/LogConfig.cc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver ts-5027-bp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1215
----
commit 94708ff7ad1b4fe74d6f37b47d3d298e3e926c26
Author: James Peach <[email protected]>
Date: 2016-11-03T04:30:47Z
TS-5027: Replace readdir_r with readdir.
Glibc deprecated readdir_r(3), so replace it with readdir(3). We
were already using readdir(3) in many places so this is just accepting
the inevitable.
(cherry picked from commit 25b16f763267546c0585fb15f43da4a7803ac984)
Conflicts:
mgmt/FileManager.cc
mgmt/MultiFile.cc
mgmt/Rollback.cc
mgmt/WebMgmtUtils.cc
proxy/http/HttpBodyFactory.cc
proxy/logging/LogConfig.cc
----
Issue Time Tracking
-------------------
Worklog Id: (was: 31900)
Time Spent: 50m (was: 40m)
> Replace readdir_r with readdir
> ------------------------------
>
> Key: TS-5027
> URL: https://issues.apache.org/jira/browse/TS-5027
> Project: Traffic Server
> Issue Type: Bug
> Components: Cleanup, Core
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> glibc deprecated {{readdir_r}} for reasons explained in the [man
> page|http://man7.org/linux/man-pages/man3/readdir_r.3.html].
> {noformat}
> ../../mgmt/Rollback.cc -fPIC -DPIC -o .libs/Rollback.o
> ../../mgmt/FileManager.cc: In member function 'SnapResult
> FileManager::removeSnap(const char*, const char*)':
> ../../mgmt/FileManager.cc:394:10: error: 'int readdir_r(DIR*, dirent*,
> dirent**)' is deprecated [-Werror=deprecated-declarations]
> while (readdir_r(dir, dirEntrySpace, &entryPtr) == 0) {
> ^~~~~~~~~
> In file included from ../../lib/ts/ink_platform.h:130:0,
> from ../../mgmt/FileManager.cc:24:
> /usr/include/dirent.h:183:12: note: declared here
> extern int readdir_r (DIR *__restrict __dirp,
> ^~~~~~~~~
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
