[ 
https://issues.apache.org/jira/browse/TS-5050?focusedWorklogId=32086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32086
 ]

ASF GitHub Bot logged work on TS-5050:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Nov/16 17:29
            Start Date: 15/Nov/16 17:29
    Worklog Time Spent: 10m 
      Work Description: Github user jrushford commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/1218#discussion_r88068883
  
    --- Diff: plugins/background_fetch/configs.cc ---
    @@ -44,8 +44,13 @@ BgFetchConfig::readConfig(const char *config_file)
         snprintf(file_path, sizeof(file_path), "%s/%s", TSInstallDirGet(), 
config_file);
         file = TSfopen(file_path, "r");
         if (nullptr == file) {
    -      TSError("[%s] invalid config file", PLUGIN_NAME);
    -      return false;
    +      TSDebug(PLUGIN_NAME, "Failed to open config file %s, trying config 
path", config_file);
    +      snprintf(file_path, sizeof(file_path), "%s/%s", TSConfigDirGet(), 
config_file);
    +      file = TSfopen(file_path, "r");
    +      if (NULL == file) {
    +        TSError("[%s] invalid config file", PLUGIN_NAME);
    +        return false;
    +      }
    --- End diff --
    
    ok, see changes.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 32086)
    Time Spent: 1h 40m  (was: 1.5h)

> The background_fetch plugin fails to check for config files relative to the 
> config dir etc/trafficserver
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TS-5050
>                 URL: https://issues.apache.org/jira/browse/TS-5050
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 6.2.0, 7.0.0, 7.1.0
>            Reporter: John Rushford
>            Assignee: John Rushford
>             Fix For: 7.1.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> We are currently using the background_fetch plugin with ATS 5.3.2 per remap.  
>  We configure the background_fetch plugin in remap.config using the relative 
> path to a config file in etc/trafficserver.  While testing ATS 6.2.1 with our 
> configs, I found that the background_fetch plugin no-longer looks for config 
> files relative to the etc/trafficserver configuration directory.
> I think that this is a regression from 5.3.2 to 6.2.x and master.  I found 
> that in configs.cc, TSConfigDirGet() is no-longer used to check for a config 
> file relative to etc/trafficserver.
> I'm testing a patch to fix this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to