[
https://issues.apache.org/jira/browse/TS-5062?focusedWorklogId=32373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32373
]
ASF GitHub Bot logged work on TS-5062:
--------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/16 21:08
Start Date: 23/Nov/16 21:08
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1233#discussion_r89399145
--- Diff: lib/ts/apidefs.h.in ---
@@ -798,6 +798,16 @@ typedef int64_t TSMgmtCounter;
typedef float TSMgmtFloat;
typedef char *TSMgmtString;
+/// The source of of management value.
+enum TSMgmtSource {
+ TS_MGMT_SOURCE_NULL, ///< No source / value not found.
+ TS_MGMT_SOURCE_DEFAULT, ///< Built in core default.
+ TS_MGMT_SOURCE_PLUGIN, ///< Plugin supplied default.
+ TS_MGMT_SOURCE_EXPLICIT, ///< Set by administrator (config file,
external API, cluster, etc.)
+ TS_MGMT_SOURCE_ENV ///< Process environment variable.
+};
--- End diff --
This should be a typedef for consistency with all the other TSAPI
enumerations.
Issue Time Tracking
-------------------
Worklog Id: (was: 32373)
Time Spent: 40m (was: 0.5h)
> traffic_ctl doesn't correctly detect plugin source for configuration variable.
> ------------------------------------------------------------------------------
>
> Key: TS-5062
> URL: https://issues.apache.org/jira/browse/TS-5062
> Project: Traffic Server
> Issue Type: Bug
> Components: Management API
> Reporter: Alan M. Carroll
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If a plugin adds configuration variables via something like
> `TSMgmtStringCreate` these are marked as "explicit" rather than plugin
> provided defaults, which means the administrator can't tell if the values are
> from the plugin or his configuration. This should be improved to be parallel
> to core configuration values where these case are distinguishable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
