Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1224#discussion_r89520379
--- Diff: lib/ts/ink_error.cc ---
@@ -61,19 +61,38 @@ ink_fatal(const char *message_format, ...)
va_list ap;
va_start(ap, message_format);
- fatal_va(message_format, ap);
+ fatal_va("Fatal: ", message_format, ap);
va_end(ap);
::exit(70); // 70 corresponds to EX_SOFTWARE in BSD's sysexits. As good
a status as any.
}
void
+ink_emergency_va(const char *fmt, va_list ap)
+{
+ fatal_va("Emergency: ", fmt, ap);
+ ::exit(UNRECOVERABLE_EXIT);
+}
+
+void
+ink_emergency(const char *message_format, ...)
+{
+ va_list ap;
+
+ va_start(ap, message_format);
+ ink_emergency_va(message_format, ap);
+ va_end(ap);
--- End diff --
Hmmm. Hasn't the process already exited by this point? Maybe best to be
safe, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
