[
https://issues.apache.org/jira/browse/TS-5056?focusedWorklogId=32399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32399
]
ASF GitHub Bot logged work on TS-5056:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/16 15:52
Start Date: 24/Nov/16 15:52
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode commented on a diff in the
pull request:
https://github.com/apache/trafficserver/pull/1224#discussion_r89520379
--- Diff: lib/ts/ink_error.cc ---
@@ -61,19 +61,38 @@ ink_fatal(const char *message_format, ...)
va_list ap;
va_start(ap, message_format);
- fatal_va(message_format, ap);
+ fatal_va("Fatal: ", message_format, ap);
va_end(ap);
::exit(70); // 70 corresponds to EX_SOFTWARE in BSD's sysexits. As good
a status as any.
}
void
+ink_emergency_va(const char *fmt, va_list ap)
+{
+ fatal_va("Emergency: ", fmt, ap);
+ ::exit(UNRECOVERABLE_EXIT);
+}
+
+void
+ink_emergency(const char *message_format, ...)
+{
+ va_list ap;
+
+ va_start(ap, message_format);
+ ink_emergency_va(message_format, ap);
+ va_end(ap);
--- End diff --
Hmmm. Hasn't the process already exited by this point? Maybe best to be
safe, though.
Issue Time Tracking
-------------------
Worklog Id: (was: 32399)
Time Spent: 20m (was: 10m)
> Implement nonrecoverable error mechanism
> ----------------------------------------
>
> Key: TS-5056
> URL: https://issues.apache.org/jira/browse/TS-5056
> Project: Traffic Server
> Issue Type: Improvement
> Components: Manager
> Reporter: Daniel Xu
> Assignee: Daniel Xu
> Fix For: 7.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There should be a mechanism for {{traffic_server}} to signal to
> {{traffic_manager}} that {{traffic_server}} cannot be recovered with any
> amount of restarting.
> For example, if TS sees a bad log file, then no amount of restarting will fix
> TS. Thus, it would be better for TM to just sit tight and wait for human
> intervention.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
