Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1210#discussion_r87404920
  
    --- Diff: plugins/experimental/log_requests/README ---
    @@ -0,0 +1,37 @@
    +log_requests
    +==============
    +
    +This plugin is used to help debug errored out transactions. 
    +We define errored out as any transaction returning a 4xx/5xx 
    +response code. By default, all transactions that return a 
    +4xx/5xx response code to the client will get its 
    +request/response headers logged into error.log.
    +
    +We also provide a blacklist flag via the plugin arguments. Take 
    +for example this config in plugin.config:
    +
    +    log_requests.so --no-log 414 502
    --- End diff --
    
    Meh. I think it would be better to have a comma separated list like 
`--no-log 414,502`. Otherwise I don't see how additional argument can be added 
later (although I suppose  you could check for leading dashes on subsequent 
arguments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to