[
https://issues.apache.org/jira/browse/TS-5082?focusedWorklogId=33147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33147
]
ASF GitHub Bot logged work on TS-5082:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/16 17:17
Start Date: 07/Dec/16 17:17
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1252
Hmmm, it seems we are incredibly inconsistent here. Why singling out this
one place for this change? Do we really need TS_INLINE in general? I notice we
turn off inlining via #define in some places, but then I'd argue that we should
not use it at all in those place, no?
I think what I'm saying is
1) Why not remove TS_INLINE ? I.e. just use inline.
2) In those places where TS_INLINE is used, but #define'd to nothing, we
just remove TS_INLINE.
3) Maybe also make an effort to reduce the use of inline in general, and
let the compiler deal with it.
I'm fine landing this as-is in this patch, but maybe file another Jira for
a general cleanup here?
Issue Time Tracking
-------------------
Worklog Id: (was: 33147)
Time Spent: 40m (was: 0.5h)
> Compile error: undefined reference to IOBufferReader::is_read_avail_more_than
> -----------------------------------------------------------------------------
>
> Key: TS-5082
> URL: https://issues.apache.org/jira/browse/TS-5082
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Oknet Xu
> Time Spent: 40m
> Remaining Estimate: 0h
>
> autoreconf -fi
> ./configure
> make
> got some error message like below:
> {code}
> CXXLD traffic_server
> undefined reference to IOBufferReader::is_read_avail_more_than(...)
> {code}
> file: P_IOBuffer.h
> {code}
> inline bool
> IOBufferReader::is_read_avail_more_than(int64_t size)
> {code}
> should be
> {code}
> TS_INLINE bool
> IOBufferReader::is_read_avail_more_than(int64_t size)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
