[
https://issues.apache.org/jira/browse/TS-5084?focusedWorklogId=33190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33190
]
ASF GitHub Bot logged work on TS-5084:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/16 20:44
Start Date: 07/Dec/16 20:44
Worklog Time Spent: 10m
Work Description: GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1253
TS-5084 Make logcat follow file rotation
This patch makes `traffic_logcat -f` follow squid.blog even when
squid.blog is rotated. Previously, the tool did not do this at all.
This is implemented by keeping track of the _most_previous_ inode #
of squid.blog and comparing it with the most up to date value of
the inode # every now and then. If there is ever a difference, then
we close and reopen the log file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-5084
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1253
----
commit fec98f307e2813e892ce93c81401f48700573d17
Author: Daniel Xu <[email protected]>
Date: 2016-12-07T20:34:57Z
TS-5084 Make logcat follow file rotation
This patch makes `traffic_logcat -f` follow squid.blog even when
squid.blog is rotated. Previously, the tool did not do this at all.
This is implemented by keeping track of the _most_previous_ inode #
of squid.blog and comparing it with the most up to date value of
the inode # every now and then. If there is ever a difference, then
we close and reopen the log file.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 33190)
Time Spent: 10m
Remaining Estimate: 0h
> Make logcat follow file rotation
> --------------------------------
>
> Key: TS-5084
> URL: https://issues.apache.org/jira/browse/TS-5084
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: Daniel Xu
> Assignee: Daniel Xu
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{traffic_logcat}} tool does not follow {{squid.blog}} if it is rotated.
> This is still occurring even when {{traffic_logcat}} is run with {{-f}} It
> would be nice if the tool would follow the log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
