Github user danobi commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1254#discussion_r91414850
  
    --- Diff: proxy/logcat.cc ---
    @@ -300,6 +307,9 @@ main(int /* argc ATS_UNUSED */, const char *argv[])
               }
             }
           }
    +      // Now that we're done reading a potentially large log file, we can 
tell the kernel that it's OK to evict
    +      // the associated log file pages from cache
    +      posix_fadvise(in_fd, 0, 0, POSIX_FADV_DONTNEED);
    --- End diff --
    
    Oops, I forgot to wrap this call in `#if`'s. Will fix soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to