GitHub user zwoop opened an issue:

    https://github.com/apache/trafficserver/issues/1286

    CID 1367521:  Low impact quality  (MISSING_MOVE_ASSIGNMENT): 
tsconfig/Errata.h and tsconfig/TsValue.h

    ```
    *** CID 1367521:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    /lib/tsconfig/Errata.h: 82 in ()
    76     
    77     /** Class to hold a stack of error messages (the "errata").
    78         This is a smart handle class, which wraps the actual data
    79         and can therefore be treated a value type with cheap copy
    80         semantics. Default construction is very cheap.
    81      */
       CID 1367521:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
       Class "ts::Errata" may benefit from adding a move assignment operator. 
See other events which show the copy assignment operator being applied to 
rvalue(s), where a move assignment may be faster.
    82     class Errata {
    83     protected:
    84         /// Implementation class.
    85         struct Data;
    86         /// Handle for implementation class instance.
    87         typedef IntrusivePtr<Data> ImpPtr;
    ```
    
    and
    
    
```________________________________________________________________________________________________________
    *** CID 1367520:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    /lib/tsconfig/TsValue.h: 420 in ()
    414     
    415     /** This holds a value from the configuration.
    416     
    417         @internal It is critical that none of the type specific 
subclasses define any data members
    418         so that instances can be freely converted to and from this base 
class.
    419     */
       CID 1367520:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
       Class "ts::config::Value" may benefit from adding a move assignment 
operator. See other events which show the copy assignment operator being 
applied to rvalue(s), where a move assignment may be faster.
    420     class Value {
    421       friend class Configuration;
    422     public:
    423       typedef Value self; ///< Self reference type.
    424       /// Default constructors.
    425       /// Creates an @c NULL instance.
    
    ```

----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to