Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1262#discussion_r94285648
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -127,10 +128,11 @@ rcv_data_frame(Http2ConnectionState &cstate, const
Http2Frame &frame)
// Check whether Window Size is acceptable
if (cstate.server_rwnd < payload_length) {
- return Http2Error(HTTP2_ERROR_CLASS_CONNECTION,
HTTP2_ERROR_FLOW_CONTROL_ERROR);
+ return Http2Error(HTTP2_ERROR_CLASS_CONNECTION,
HTTP2_ERROR_FLOW_CONTROL_ERROR,
+ "recv data cstate.server_rwnd < payload_length");
}
if (stream->server_rwnd < payload_length) {
- return Http2Error(HTTP2_ERROR_CLASS_STREAM,
HTTP2_ERROR_FLOW_CONTROL_ERROR);
+ return Http2Error(HTTP2_ERROR_CLASS_STREAM,
HTTP2_ERROR_FLOW_CONTROL_ERROR, "recvdata stream->server_rwnd <
payload_length");
--- End diff --
"recv data" -- please add a space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
