[
https://issues.apache.org/jira/browse/TS-2888?focusedWorklogId=34583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34583
]
ASF GitHub Bot logged work on TS-2888:
--------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/17 22:31
Start Date: 03/Jan/17 22:31
Worklog Time Spent: 10m
Work Description: GitHub user persiaAziz opened a pull request:
https://github.com/apache/trafficserver/pull/1299
TS-2888: remove vararg and format parameters from build_error_resoponse
This removes vararg and the formatting parameter from build_error_response.
However the underlying fabricate_with_old_api still needs to be cleaned up. Not
sure if someone is already working on the cleaning.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/persiaAziz/trafficserver TS-2888
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1299
----
commit 94e4a7b688df7edd2e47a3046fb6326845e1a294
Author: Persia Aziz <[email protected]>
Date: 2017-01-03T22:19:19Z
TS-2888: remove vararg and format parameters from build_error_resoponse
----
Issue Time Tracking
-------------------
Worklog Id: (was: 34583)
Time Spent: 10m
Remaining Estimate: 0h
> Fix build_error_response() to not take a vararg and perhaps not even a format
> -----------------------------------------------------------------------------
>
> Key: TS-2888
> URL: https://issues.apache.org/jira/browse/TS-2888
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core, HTTP
> Reporter: Leif Hedstrom
> Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As the body factory is now required, build_error_response() has a legacy
> option which generally is not used (except one case which I'm hoping to fix
> as well). I've already fixed most usage as part of TS-2886, those additional
> format strings would never have been used after we made body factory
> mandatory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
