Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1294#discussion_r94530155
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -44,8 +57,7 @@ fastopen_destroy(BIO *bio)
if (bio) {
// We expect this BIO to not own the socket, so we must always
// be in NOCLOSE mode.
- ink_assert(bio->shutdown == BIO_NOCLOSE);
- fastopen_create(bio);
+ ink_assert(BIO_get_shutdown(bio) == BIO_NOCLOSE);
--- End diff --
The `Data` struct is getting leaked here, but (see above) I think we can
get away without it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
