Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1294#discussion_r94717030
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -58,26 +57,26 @@ fastopen_bwrite(BIO *bio, const char *in, int insz)
errno = 0;
BIO_clear_retry_flags(bio);
- ink_assert(bio->num != NO_FD);
+ ink_assert(BIO_get_fd(bio, nullptr) != NO_FD);
--- End diff --
Rather than calling `BIO_get_fd` multiple times, call it once and stash the
fd in a local variable. Same for the write path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
