Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1226#discussion_r94825933
--- Diff: iocore/net/SSLNetVConnection.cc ---
@@ -980,7 +980,20 @@ SSLNetVConnection::sslStartHandShake(int event, int
&err)
case SSL_EVENT_CLIENT:
if (this->ssl == nullptr) {
- this->ssl = make_ssl_connection(ssl_NetProcessor.client_ctx, this);
+ SSL_CTX *clientCTX = nullptr;
+ if (this->options.clientCertificate) {
+ const char *certfile = (const char
*)this->options.clientCertificate;
+ if (certfile != nullptr) {
+ clientCTX = params->getCTX(certfile);
+ if (clientCTX != nullptr)
+ Debug("ssl", "context for %s is found at %p",
this->options.clientCertificate.get(), (void *)clientCTX);
+ else
+ Debug("ssl", "failed to find context for %s",
this->options.clientCertificate.get());
+ }
+ } else {
+ clientCTX = ssl_NetProcessor.client_ctx;
+ }
--- End diff --
Should we use the same logic to fetch the default client cert as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
