[
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34989&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34989
]
ASF GitHub Bot logged work on TS-5107:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/17 16:33
Start Date: 08/Jan/17 16:33
Worklog Time Spent: 10m
Work Description: Github user jablko commented on the issue:
https://github.com/apache/trafficserver/pull/1303
> The ``inliner`` parameter takes an instance of `states.Inliner` or a
subclass.
> It handles inline markup recognition. A common extension is the addition
of
> further implicit hyperlinks, like "RFC 2822". This can be done by
subclassing
> `states.Inliner`, adding a new method for the implicit markup, and adding
a
> ``(pattern, method)`` pair to the "implicit_dispatch" attribute of the
> subclass. See `states.Inliner.implicit_inline()` for details.
https://sourceforge.net/p/docutils/code/HEAD/tree/trunk/docutils/docutils/parsers/rst/__init__.py#l59
This is exactly what we're doing. I think it's okay that Docutils added the
init_customizations() method between versions -- it sounds like it was their
only option.
I don't have a strong sense yet how we want to reference GitHub issues (are
there any cases yet?) so it's hard to judge whether consistency between Jira
and GitHub is desirable. One thing I personally like about TS-1234 (for Jira)
is that we use the same in commit messages, source code comments, etc. so it's
consistent in that sense.
Issue Time Tracking
-------------------
Worklog Id: (was: 34989)
Time Spent: 2h 40m (was: 2.5h)
> ATS 7.0.0 doesn't build against python docutils 0.13.1
> ------------------------------------------------------
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
> Issue Type: Bug
> Components: Documentation
> Reporter: Jean Baptiste Favre
> Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c . -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [ 0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
> File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
> which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
