Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1325
Afaict this is just strcmp then?
> On Jan 13, 2017, at 7:03 PM, Leif Hedstrom <[email protected]>
wrote:
>
> @zwoop commented on this pull request.
>
> In lib/records/RecUtils.cc:
>
> > @@ -419,7 +419,7 @@ RecDataSetFromString(RecDataT data_type, RecData
*data_dst, const char *data_str
> data_src.rec_float = atof(data_string);
> break;
> case RECD_STRING:
> - if (data_string && strcmp((data_string), "nullptr") == 0) {
> + if (data_string && (strlen(data_string) == 4) &&
strncmp((data_string), "NULL", 4) == 0) {
> Because amc wanted me to use strncmp(), so if you don't check the length,
then it'd also match any string starting with NULL.
>
> â
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
