GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/1397
TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB
AC_SEARCH_LIBS always adds -llibrary to LIBS, but AC_CHECK_LIB doesn't
check that the function isn't already available -- in which case the
library isn't required. So prefer AC_SEARCH_LIBS. Use AC_CHECK_LIB only
if 1) we want to leave LIBS alone, and 2) the function isn't likely to
be provided by some other library -- the standard C library, for
example. If there's a chance that the function might already be
available, use AC_SEARCH_LIBS, but save and restore LIBS as needed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver libs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1397
----
commit cc4b8c72ed5ad7059ad5c6f44ba2616556f69172
Author: Jack Bates <[email protected]>
Date: 2017-01-30T22:28:28Z
TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB
AC_SEARCH_LIBS always adds -llibrary to LIBS, but AC_CHECK_LIB doesn't
check that the function isn't already available -- in which case the
library isn't required. So prefer AC_SEARCH_LIBS. Use AC_CHECK_LIB only
if 1) we want to leave LIBS alone, and 2) the function isn't likely to
be provided by some other library -- the standard C library, for
example. If there's a chance that the function might already be
available, use AC_SEARCH_LIBS, but save and restore LIBS as needed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
