Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1420#discussion_r99900589
  
    --- Diff: proxy/logging/LogBuffer.cc ---
    @@ -615,10 +618,14 @@ LogBuffer::resolve_custom_entry(LogFieldList 
*fieldlist, char *printf_str, char
             }
     
             bytes_written += res;
    -        field = fieldlist->next(field);
    +        lastField = field;
    +        field     = fieldlist->next(field);
           } else {
             Note("There are more field markers than fields;"
    -             " cannot process log entry");
    +             " cannot process log entry '%.*s'. Last field = '%s' 
printf_str='%s' pos=%d/%d count=%d alt_printf_str='%s'",
    +             bytes_written, write_to, lastField == nullptr ? "*" : 
lastField->symbol(),
    --- End diff --
    
    Hmmm, maybe it's completely unrealistic, but couldn't lastField be NULL 
here ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to