Github user zwoop commented on the issue:

    https://github.com/apache/trafficserver/pull/1381
  
    This still has 
    
    1) clang-format issues
    
    2) Compile issues:
    
    ```
    In file included from ../../../lib/ts/test_Scalar.cc:24:
    /var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:68:34: 
error: member reference base type 'S *' (aka 'Scalar<N, C, T> *') is not a 
structure or union
        return static_cast<S *>(this).operator+=(static_cast<C>(n));
               ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
    /var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:74:34: 
error: member reference base type 'S *' (aka 'Scalar<N, C, T> *') is not a 
structure or union
        return static_cast<S *>(this).operator-=(static_cast<C>(n));
               ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
    /var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:80:34: 
error: member reference base type 'S *' (aka 'Scalar<N, C, T> *') is not a 
structure or union
        return static_cast<S *>(this).operator*=(static_cast<C>(n));
               ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
    /var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:86:34: 
error: member reference base type 'S *' (aka 'Scalar<N, C, T> *') is not a 
structure or union
        return static_cast<S *>(this).operator/=(static_cast<C>(n));
               ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
    /var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:912:57: 
error: default initialization of an object of const type 'const 
ApacheTrafficServer::detail::tag_label_B' requires a user-provided default 
constructor
      static ApacheTrafficServer::detail::tag_label_B const b;
    ```
    
    Also, probably want to rebase again, it's been a while so the list of 
changes is long ;).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to