GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/1434
Clang fixes
This is a back-port PR of various clang-analyzer fixes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver clang_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1434.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1434
----
commit 5dd8bffbb8bb39c4f0fc89e853bab1c747e7d0a9
Author: Bryan Call <[email protected]>
Date: 2016-05-25T17:43:46Z
TS-4367: Failed clang-analyzer, memory leak in mgmt/api
(cherry picked from commit 1cff52240584e5e6dccee63a02ab70ce61a961a2)
commit 1ea2edc222fd3e65bca61a6afc2555d86ba24b6d
Author: Gancho Tenev <[email protected]>
Date: 2016-04-26T19:30:24Z
TS-4366 Uninitialized stack value used in mp4 plugin
It is possible that there are cases where IOBufferReaderCopy() does not
modify
the input buffer (copy 0 bytes) which leaves the buffer uninitialized which
is
undesirable since the buffers are always allocated on the stack.
Addressed it in one of 2 ways:
(1) memset(buffer, 0, sizeof(buffer)) or
(2) check IOBufferReaderCopy() return value and handle accordingly.
These changes are meant to only address using uninitialized values
allocated on
the stack, avoiding bigger changes since regression tests are not available
to
properly verify functionality.
This closes #656
(cherry picked from commit 77bd40ba19f29b11873c1709485b64840d137dde)
Conflicts:
plugins/experimental/mp4/mp4_meta.cc
commit a15bbe1bb7c1358f7b709b32a4c810b49e3d1ad5
Author: Bryan Call <[email protected]>
Date: 2016-05-26T17:15:51Z
TS-4479: Clang-analyzer failure, Potential memory leak
(cherry picked from commit 87d1fc5d17d82ebb8f06f4138ca82b6e3b57179c)
commit 9ab713edd958db3f02526664423a7e4894ffa567
Author: James Peach <[email protected]>
Date: 2016-06-21T00:21:17Z
Remove dead store.
(cherry picked from commit 67efb389b890919237248ed437c7af1d01559bf1)
commit d5b6a5f1d393cb1541004de3c8368dbffb8f02ab
Author: shinrich <[email protected]>
Date: 2016-08-10T20:00:43Z
TS-4729: Fix dead assignment.
(cherry picked from commit 29bc28a713463eb815524a91e03be95fe3aeedb1)
Conflicts:
proxy/http2/Http2Stream.cc
proxy/http2/Http2Stream.h
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
