Github user jablko commented on the issue:
https://github.com/apache/trafficserver/issues/1437
Hmm -- I see what you mean -- BoringSSL sock_read() and sock_write() have
used bio_fd_non_fatal_error() since [1], which claims to be a fork from
https://github.com/openssl/openssl/commit/30ea570f0fb2717b1faca5d611a3ab200c8eac83,
however in OpenSSL, they've used BIO_sock_non_fatal_error() since their
inception -- and in particular in
https://github.com/openssl/openssl/commit/30ea570f0fb2717b1faca5d611a3ab200c8eac83
[2]. I wonder why BoringSSL made this change?
So for fastopen_bread() and fastopen_bwrite(), BIO_sock_non_fatal_error()
is correct, and I'm tempted to just copy it from OpenSSL, for implementations
that lack it (BoringSSL)?
[1]
https://boringssl.googlesource.com/boringssl/+/95c29f3cd1f6c08c6c0927868683392eea727ccb
[2]
https://github.com/openssl/openssl/blob/30ea570f0fb2717b1faca5d611a3ab200c8eac83/crypto/bio/bss_sock.c
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
