Github user jablko commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1440#discussion_r100845545
--- Diff: lib/raft/raft_impl.h ---
@@ -338,8 +338,8 @@ template <typename Server> class RaftImpl : public
Raft<Server>
if (!i_am_leader())
return;
// Attempt to pass leadership to a worthy successor.
- const ::std::string *best_node = nullptr;
- NodeState *best = nullptr;
+ const ::std::string *best_node = NULL;
+ NodeState *best = NULL;
--- End diff --
NBD, but this instance isn't from an upstream backport, right? This has
been nullptr since inception in 38e1d741f2056a7893a0a90452d37a29ae9bf707, which
goes back to 6.0.x?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
