Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1464#discussion_r101878798
--- Diff: proxy/InkAPI.cc ---
@@ -8153,6 +8153,10 @@ _conf_to_memberp(TSOverridableConfigKey conf,
OverridableHttpConfigParams *overr
typ = OVERRIDABLE_TYPE_STRING;
ret = &overridableHttpConfig->client_cert_filepath;
break;
+ case TS_CONFIG_PARENT_FAILURES_UPDATE_HOSTDB:
+ typ = OVERRIDABLE_TYPE_INT;
--- End diff --
Now that I see this, this type should probably be 'byte'. See some of the
earlier examples how to do that (both in the SM structs as well as here).
OVERRiDABLE_TYPE_BYTE is also the default, and we should use that (I probably
need to take a look at this, to make sure it's done correctly elsewhere as
well).
Also, I think the way this was written, the string types were all collected
towards the end. Not sure that's important any more, but might be worth keeping
that semantics?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
