GitHub user ykopel opened a pull request:
https://github.com/apache/trafficserver/pull/1472
condition that cause always passthrough bypass
Fix for apache@497e475.
This commit contains a condition that will always be true.
This is because ua_raw_buffer_reader->read_avail() always will be grater
than zero.
You haven't see it until now because of another bug
(https://github.com/apache/trafficserver/pull/1471) that cause
is_transparent_passthrough_allowed() to be always false and this for it never
reached to your lines.
This is why I suggest to just delete those lines meantime.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykopel/trafficserver tr-pass
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1472
----
commit edcd7de1b3b79b3c0da4b717bf13c7395c86646e
Author: Yakov Kopel <[email protected]>
Date: 2017-02-19T07:55:07Z
condition that cause always passthrough bypass
Fix for apache@497e475.
This commit contains a condition that will always be true.
This is because ua_raw_buffer_reader->read_avail() always will be grater
than zero.
You haven't see it until now because of another bug (5817738) that cause
is_transparent_passthrough_allowed() to be always false and this for it never
reached to your lines.
This is why I suggest to just delete those lines meantime.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
