Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1488#discussion_r103039976
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2007,7 +2007,10 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
if (ssl_extract_certificate(&line_info, sslMultiCertSettings)) {
// There must be a certificate specified unless the tunnel
action is set
if (sslMultiCertSettings.cert || sslMultiCertSettings.opt !=
SSLCertContext::OPT_TUNNEL) {
- ssl_store_ssl_context(params, lookup, &sslMultiCertSettings);
+ if (ssl_store_ssl_context(params, lookup,
&sslMultiCertSettings) == nullptr) {
+ Error("failed to load SSL server contexts");
+ return false;
+ }
} else {
--- End diff --
I'd be fine adding additional actionable checks here if you like, I'm just
not familiar with most of this code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
