Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1299#discussion_r103734216
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8299,10 +8291,9 @@ HttpTransact::build_redirect_response(State *s)
//////////////////////////
s->free_internal_msg_buffer();
s->internal_msg_buffer_fast_allocator_size = -1;
- s->internal_msg_buffer =
body_factory->fabricate_with_old_api_build_va(
- "redirect#moved_temporarily", s, 8192, &s->internal_msg_buffer_size,
body_language, sizeof(body_language), body_type,
- sizeof(body_type), "%s <a href=\"%s\">%s</a>. %s.", "The document you
requested is now", new_url, new_url,
- "Please update your documents and bookmarks accordingly", NULL);
+ s->internal_msg_buffer = body_factory->getFormat(8192,
&s->internal_msg_buffer_size, "%s <a href=\"%s\">%s</a>. %s.",
--- End diff --
Add a comment here that this is necessary because the template format
doesn't have access to this computed URL and there is no current way to provide
that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
