Github user shukitchan commented on the issue:

    https://github.com/apache/trafficserver/pull/1534
  
    👍 
    Looks good. 
    Just one question. Should the internal "protocol_contains" functions return 
"StringView" as well? 
    Obviously we should not be changing the return type of public API. But 
internally should we be using "StringView" for those internal api calls?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to