Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1534#discussion_r105075862
--- Diff: iocore/net/P_UnixNetVConnection.h ---
@@ -149,21 +149,21 @@ class UnixNetVConnection : public NetVConnection
// called when handing an event from this NetVConnection,//
// or the NetVConnection creation callback. //
////////////////////////////////////////////////////////////
- virtual void set_active_timeout(ink_hrtime timeout_in);
- virtual void set_inactivity_timeout(ink_hrtime timeout_in);
- virtual void cancel_active_timeout();
- virtual void cancel_inactivity_timeout();
- virtual void set_action(Continuation *c);
- virtual void add_to_keep_alive_queue();
- virtual void remove_from_keep_alive_queue();
- virtual bool add_to_active_queue();
+ void set_active_timeout(ink_hrtime timeout_in) override;
+ void set_inactivity_timeout(ink_hrtime timeout_in) override;
+ void cancel_active_timeout() override;
+ void cancel_inactivity_timeout() override;
+ void set_action(Continuation *c) override;
+ void add_to_keep_alive_queue() override;
+ void remove_from_keep_alive_queue() override;
+ bool add_to_active_queue() override;
virtual void remove_from_active_queue();
--- End diff --
@bryancall Note `remove_from_active_queue` does not override anything, in
contrast to the rest of this group of methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
