Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1559#discussion_r105187896
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -271,9 +271,22 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
// if it is a non-temporary error, we should die appropriately
if (err && err != EAGAIN && err != EINTR) {
- read_signal_error(nh, vc, err);
+ Continuation *reader_cont = vc->read.vio._cont;
+
+ if (read_signal_error(nh, vc, err) == EVENT_DONE) {
+ return;
+ }
+ // If vc is closed or shutdown(WRITE) in last read_signal_error
callback,
+ // or reader_cont is same as write.vio._cont.
--- End diff --
Great comment, this really helps explaining the issue / solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
