Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1502#discussion_r106057816
--- Diff: proxy/ControlMatcher.cc ---
@@ -220,6 +220,7 @@ HostMatcher<Data, MatchResult>::NewEntry(matcher_line
*line_info)
if (error.failed()) {
// There was a problem so undo the effects this function
memset(cur_d, 0, sizeof(Data));
+ new(cur_d) Data(); //reconstruct
--- End diff --
This makes sense to me, but do we still need the memset()? It's obviously
harmless if not necessary, mostly curious.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
