Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1567#discussion_r106482070
  
    --- Diff: proxy/logging/LogObject.h ---
    @@ -299,6 +299,10 @@ class LogObject : public RefCountObj
       unsigned m_buffer_manager_idx;
       LogBufferManager *m_buffer_manager;
     
    +  // scrubbing data -- helps us scrub buffers of sensitive data
    +  bool scrub_enabled = false;
    --- End diff --
    
    Are both of these needed? Does not `scubber` suffice by being null or not 
null?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to