Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1623#discussion_r109180096
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
return addr;
}
-/*-------------------------------------------------------------------------
- LogBuffer::LogBuffer
--- End diff --
IMO it wasn't saying anything informative or useful now that AbstractBuffer
is gone. If I had to add a comment it would be about what LogBuffer does and I
would prefer to do that in LogBuffer.h.
I'm deep into the weeds of the logging system right now. Afterwards, I'll
fix up and add more documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
